Member-only story
The Four Types of Code Reviews
Code reviewing has been going on long before the pull request model. Here are four methods worth knowing to help your team review code
Many engineers who have read my blog will know I talk a lot about code reviews. I firmly believe that a healthy code review practice is a critical tool for building a great team. It’s easier to build great software if people feel safe enough to ask questions, are generous in sharing their knowledge, and welcome feedback. Code reviews help build all of those things.
But many engineers assume that the only way to review code is via the pull request model. Pull requests are the default method for reviewing code — my writings on code reviews center around the pull request model, too, including my upcoming book! — but it isn’t the only way to review code.
In this article, I want to give a brief overview of four types of code reviews I’ve seen used by teams. The goal isn’t to show that one is better or worse than the other; the goal is to show that each is different. As an engineer, knowing when and how to utilize each of these methods properly will help your career. I know they’ve helped mine.
